search

gangstead / atom-incremental-search

Incremental search for the Atom editor
MIT License
16 stars 13 forks source link

Prevent <atom-panel> pileup after multiple searches #59

Closed pkhpkh closed 5 years ago

pkhpkh commented 8 years ago

InputView was inconsistent with its creation and destruction of @inputPanel -- if the View was detached, it would always create a new input panel. When a search was finished (with core:close or core:cancel), the view was detached, but the panel that had been created wasn't removed. (In the core:cancel case, it was at least hidden.)

This led to a pile of empty <atom-panel> elements.

It was easier to destroy and recreate the panel every time instead of trying to keep it around, but hiding it and showing it (and only creating it once) would be another solution to the problem.

gangstead commented 8 years ago

So if I'm reading this correctly, since we are creating/destroying the panel now we no longer need this hide statement?