gangstead / atom-incremental-search

Incremental search for the Atom editor
MIT License
16 stars 13 forks source link

Deprecated selector in `incremental-search\styles\isearch.less` #69

Closed LUDZpro closed 5 years ago

LUDZpro commented 6 years ago

In incremental-search\styles\isearch.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

pbgc commented 6 years ago

It's always good to see other issues... This is duplicating #66 that already has 1year.... I already submitted a PR that fixes this 10months ago... But the repo owner does not merge it. I use my fork, git clone it and install it locally.