Code Review : Project 2 #Grid View Image Search

[gangwalgaurav]

"/cc @codepathreview @codepath" @codepathreview @codepath

In the demo, at the end when I was clicking on image to make it full screen, the internet connection was flaky (as we can see in status bar, the Wifi was intermittently connected) some of the full screen images was shown instead of actual Images.

[codepathreview]

:+1: Excellent job, Gaurav!! Few notes after checking the code:

• Good to see you used a filters object to represent the filters to apply to the query
• Consider using Parcelable instead of Serializable
• Properly used spinners (with populated values) to allow users to select filters
• Nice effort on improving the UI/UX including modal overlay
• Nice job adding the share intent to the image detail view!
• Nice to see you added the search box to the ActionBar!
• Correctly used StaggeredGridView and TouchImageView
• Consider adding progress bars to your app whenever a network request goes out in addition to the placeholder images.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.