search

ganhongyao / pe

0 stars 0 forks source link

Able to add duplicate names (case insensitive) #2

Open ganhongyao opened 2 years ago

ganhongyao commented 2 years ago

UG specifies the names must be unique:

image.png

Screenshot:

image.png

Even though the cases do not match completely, they are still likely to mean the same person.

From module website:

image.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Suspiciously alike duplicate person

Steps to reproduce:

  1. Add a person John Doe with all details.

  2. Add another person with different name and different details.

  3. Edit details to match John Doe's but let the name differ in terms of casing by just one character.

This is not desirable as they are basically duplicates (improper duplicate detection).


Expected:

Duplicate detected and alerts the user.


Actual: Successfully adds person.


Screenshots:

image.png

[original: nus-cs2103-AY2122S1/pe-interim#3437] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We agree that allowing users to have suspiciously alike duplicate person is a feature flaw but we think that severity should be low as it is quite unlikely for a typical user to try and add two or more contacts of people with the same names but different capitalisation.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]