search

ganhongyao / pe

0 stars 0 forks source link

Specifying duplicate tag names has unspecified behaviour #9

Open ganhongyao opened 2 years ago

ganhongyao commented 2 years ago

image.png

Only one tag is added. This behaviour is not specified anywhere in the UG.

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Handling of duplicate tags with the same name

Duplicate tags with the same name are combined to a single tag, which is unexpected behaviour. The documentation only limits the tag length, and not the name, so either the documentation should specify that the tags cannot be duplicated or the functionality is bugged. I believe this is more likely to be a documentation issue as this was the default implementation in AB-3's tag handling.

Steps to Reproduce:

  1. Add/edit a user to have multiple tags with the same name. (in my case, I used add n/John t/idk t/idk)

Expected:

  1. Duplicate tags are displayed

Actual Result: Duplicate tags are combined image.png

[original: nus-cs2103-AY2122S1/pe-interim#2004] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We are rejecting this as a documentation bug as we do not see a reason why the user wants the same tag to show multiple times on a task. By default, this should be expected behaviour without explicitly mentioning this in UG which we do not want to clog up with unnecessary information.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: > we do not see a reason why the user wants the same tag to show multiple times on a task

This is clearly an assumption by the developers.

The assumption may not be true. For example, the user may want to have 2 of the same tag "important" to emphasise the importance of a contact and make the contact stand out.

Even if the assumption is valid, it should still be made clear in the UG. Users who see this behaviour would be extremely confused when they are unable to find this documented anywhere.