search

ganigeorgiev / hide-ratings-extension

Chrome extension to hide/blur the rating bars from IMDB, Goodreads, MyAnimeList and Letterboxd search results, lists and reviews.
MIT License
15 stars 6 forks source link

Firefox Releases #12

Open nithssh opened 1 month ago

nithssh commented 1 month ago

Hey,

This extension is already fully compatible with Firefox when tested, and only needs to be released for Firefox along with chrome.

According to the porting guide, it isn't recommended to make any changes to the code if the only changes required are browser API namespace changes ('chrome' -> 'browser'), which happens to be the only required changes here.

For abstracting over these API namespace differences there is a CLI tool by Mozilla called web-ext. We only need to go into the repo's directory, and run web-ext build and it will emit a .zip file with these browser abstractions made, which you can then publish. You can even test this zip in chrome, and if it works (which it should), you can unzip it and upstream those abstractions into the codebase if you like.

Would you please consider release management for Firefox along with chrome too? There are currently ~96 users of the Firefox 'fork', I can transfer the ownership of that Addons store listing to you. Sorry about the pointless fork, I was a highschooler who didn't understand How to Open Source at that time. I was looking into upstreaming it and realized there is nothing to upstream. You only need to do releases management.

Please let me know what you think about this. Thanks!

Nithish

nithssh commented 1 month ago

Here is a patch for a minor manifest change that is required for Firefox. You can find more details in the commit message.

0001-Add-Firefox-specific-IDs-mandated-for-V3-extensions.patch.txt

ganigeorgiev commented 1 month ago

I don't have a sandboxed VM prepared at the moment to download random files.

I'll consider publishing a Firefox version in the future, but there are no ETAs.

If you have already published a Firefox extension port, to make the eventual future transition easier you can try to give your extension a distinct/unique name (e.g. appending "port" or something else) so that it doesn't conflict with the used name in the current manifest.