Prev/Next Buttons generated without type="button"

ganlanyuan / tiny-slider

Vanilla javascript slider for all purposes.

MIT License

5.24k stars 784 forks source link

Prev/Next Buttons generated without type="button" #381

Open stu-fu opened 5 years ago

stu-fu commented 5 years ago

Issue description:

<button> elements generated by tiny-slider are missing the type="button" attribute. This is causing pages using webforms to refresh any time one of these buttons get pressed.

thewrush commented 5 years ago

Experiencing the same issue here. For now, I'll have to add type button using JS.

trailsnail commented 4 years ago

Think it will be fixed with https://github.com/ganlanyuan/tiny-slider/pull/382

mark-at-tusksoft commented 4 years ago

I'm on v2.9.2 and getting this issue. When will this fix be released and hosted on a cdn?

Hotfixing with the following jQuery after calling tns() in the meantime: $(".tns-controls button").attr("type", "button");