search

ganlanyuan / tiny-slider

Vanilla javascript slider for all purposes.
MIT License
5.24k stars 786 forks source link

[aria-*] attributes do not match their roles #824

Open saidaLachgar opened 1 year ago

saidaLachgar commented 1 year ago

Issue description: slides are lowering google insights score because of Accessibility, is it possible to avoid using [aria-*] attributes ? same thing for buttons, they don't have an aria label if i changed the controlsText to svg icons Tiny-slider version: 2.9.4 Browser name && version: Any OS name && version: Any

image image

chuckneely commented 1 year ago

⬆️ Second this, our Accessibility score is being impacted negatively due to the same error in TNS slides/controls:

"[aria-*] attributes do not match their roles".

Ideally it would be great if we had control over the aria labels/roles, or that they should have valid implementation by default

szildaniel commented 7 months ago

@ganlanyuan Same problem in project that I work on. BtW Thank you for your outstanding work on the slider. I appreciate your dedication. Would be grat If you provide the option for controlling ARIA elements within the slider :)