search

ganto / copr-lxc3

RPM spec files for building lxc-3 on Fedora COPR
MIT License
8 stars 2 forks source link

ignore non-existant rpath tag in libdqlite.so #19

Closed gsfjohnson closed 4 years ago

gsfjohnson commented 5 years ago

Attempts to rpmbuild in centos/7 on raspi4 fail during %install because rpath tag doesn't exist in libdqlite.so. This change checks for rpath tag before attempting to replace it. Open to alternative methods.

ganto commented 5 years ago

Thanks for your feedback. I've never tried to build it on another architecture that's why the corresponding copr repos are not enabled.

Actually I'm not even sure if the rpath statement is still needed. Afaik this comes still from a time, where the libdir couldn't be set via configure (or at least I didn't realize how). Can you check if it would also work if the rpath invocation would be completely removed? Sorry, I always forgot about that when I was preparing a new release.

ganto commented 5 years ago

Thanks a lot for your fix. I'll add it to the spec file and see if I can enable the aarch64 repos in COPR. Please give me some time.

gsfjohnson commented 5 years ago

Sorry, I meant to respond (as well as providing the updated commit). With the provided change, your spec file successfully builds on RPi4 + CentOS 7, the resulting rpms install, and the binaries run. I wanted to also build-test on x86_64, but my Proxmox system is out of date and is throwing problems, so that series of build/install/run test was not completed. Just FYI. Thanks for the responses.