search

ganto / copr-lxc4

RPM spec files for building the latest stable lxc/lxd/incus releases on Fedora COPR
MIT License
34 stars 7 forks source link

Apply patch to configure spice using -spice parameter #14

Closed subpop closed 3 years ago

subpop commented 3 years ago

Applies a patch to enable lxd to work with qemu >= 5.2.0.

Fixes #13

ganto commented 3 years ago

Hmn, sorry, saw it too late. Just updated to lxd-4.13. It seems this patch is still missing there. Will include them tomorrow.

ganto commented 3 years ago

Could you please rebase your PR to the current master and remove the changes of the .tito/packages/lxd file and the changelog. Those will be automatically generated.

subpop commented 3 years ago

I hope the commit message is okay. I'm not sure what tito wants.

ganto commented 3 years ago

I hope the commit message is okay. I'm not sure what tito wants.

Sorry to bother you one last time. The "Automatic commit... " are commits done by tito so it's weird if you manually commit something with such a commit message. Can you please adjust the commit message to what this commit actually does? This is what goes into the changelog at the end. Something like what you wrote in the issue title.

After that I'm fine to merge. Sorry for these delays, I didn't had much time to have a closer look at it the past few days.

subpop commented 3 years ago

No worries! Like I said, tito is new to me, and it seems to do a lot automatically, so I'm not clear where it needs human input. I just amended the commit and force-pushed a new one.

ganto commented 3 years ago

Great, thanks. I'll test this and then create another package once I checked that everything is fine.