gantoreno / vscode-vercel

▲ A carefully crafted set of colorschemes that are faithful to Next.js & Vercel's docs
MIT License
3 stars 0 forks source link

The selected text effect is not very obvious. #1

Open u3u opened 2 months ago

u3u commented 2 months ago

I really like this theme because it is the closest to the effect of ray.so ! Can you optimize the effect of selecting text? In addition, https://github.com/raycast/ray-so has been open sourced. Can the latest accurate highlight colors be synchronized?

u3u commented 2 months ago

I temporarily use settings to override the theme.

https://ray.so/#theme=vercel&padding=64 https://github.com/raycast/ray-so/blob/eb303710b39b407c5400b05837a3eb91bd1ec074/app/(navigation)/(code)/store/themes.ts#L88-L136

{
  "editor.tokenColorCustomizations": {
    "[Vercel (Dark)]": {
      // "foreground": "hsla(0, 0%, 93%,1)",
      // "constant": "oklch(71.7% 0.1648 250.79360374054167)",
      // "string": "oklch(73.1% 0.2158 148.29)",
      // "comment": "hsla(0, 0%, 63%,1)",
      // "keyword": "oklch(69.36% 0.2223 3.91)",
      // "parameter": "oklch(77.21% 0.1991 64.28)",
      // "function": "oklch(69.87% 0.2037 309.51)",
      // "stringExpression": "oklch(73.1% 0.2158 148.29)",
      // "punctuation": "hsla(0, 0%, 93%,1)",
      // "link": "oklch(73.1% 0.2158 148.29)",
      // "number": "#ffffff",
      // "property": "oklch(71.7% 0.1648 250.79360374054167)",
      // "highlight": "oklch(30.86% 0.1022 255.21)",
      // "highlightHover": "oklch(30.86% 0.1022 255.21 / 30%)",
      // "highlightBorder": "oklch(71.7% 0.1648 250.79360374054167)",
      "comments": "#A1A1A1",
      "functions": "#C472FB",
      "keywords": "#FF4D8D",
      "numbers": "#FFFFFF",
      "strings": "#00CA50",
      "textMateRules": [
        {
          "scope": [
            "constant.language.boolean",
            "constant.numeric",
            "support.class.component",
            "support.type.primitive",
            "variable.other.constant",
            "variable.other.object"
          ],
          "settings": {
            "foreground": "#47A8FF"
          }
        },
        {
          "scope": ["entity.name.type", "entity.other"],
          "settings": {
            "foreground": "#C472FB"
          }
        },
        {
          "scope": ["entity.name.tag"],
          "settings": {
            "foreground": "#00CA50"
          }
        },
        {
          "scope": [
            "punctuation.definition.block",
            "variable.object.property",
            "variable.parameter"
          ],
          "settings": {
            "foreground": "#EDEDED"
          }
        },
        {
          "scope": ["keyword.operator", "storage.type.function.arrow"],
          "settings": {
            "foreground": "#FF4D8D"
          }
        }
      ],
      "types": "#FF4D8D",
      "variables": "#FF4D8D"
    }
  },
  "workbench.colorCustomizations": {
    "[Vercel (Dark)]": {
      "editor.findMatchBackground": "default",
      "editor.findMatchBorder": "default",
      "editor.findMatchForeground": "default",
      "editor.findMatchHighlightBackground": "default",
      "editor.findMatchHighlightBorder": "default",
      "editor.findMatchHighlightForeground": "default",
      "editor.selectionBackground": "default",
      "editor.selectionForeground": "default",
      "editor.selectionHighlightBackground": "default",
      "editor.selectionHighlightBorder": "default",
      "editorOverviewRuler.findMatchForeground": "default",
      "foreground": "#EDEDED"
    }
  }
}
gantoreno commented 2 months ago

Hey there! Thank you so much for digging into this - and for trying out the theme as well!

I haven't had too much time to jump back into this repo, as I switched jobs and things have been all over the place, but I'll try to see if I can fit in these changes either this weekend or the next one perhaps. Also, thanks for linking the file from the original repo! That's going to come in really handy 👍🏻