Some URLs cannot be fetched

gantree-io / gantree-lib-nodejs

Javascript lib for gantree-cli

Apache License 2.0

12 stars 3 forks source link

Some URLs cannot be fetched #40

Open lovelaced opened 4 years ago

lovelaced commented 4 years ago

Doesn't seem to work with google storage signed URLs specifically. Offending line is here. Removing the "| quote" seems to fix it.

rozifus commented 4 years ago

Thanks for this, I'm not sure why the "| quote" was added there tbh, I think it should be fine to remove it.

If there's something I'm missing in terms of parsing the url and removing the quote causes an issue I think we can resolve it in the Gantree inventory generation stage before the value is sent to ansible