search

gantry / gantry5

:rocket: Next Generation Template / Theme Framework
http://gantry.org
1.04k stars 204 forks source link

Add support for Fontawesome 5 #2196

Closed ghost closed 3 years ago

ghost commented 6 years ago

Since Fontawesome 5 is now available and uses SVG's it would be nice to provide support for this within Gantry5. Fortunately Fontawesome do provide a mechanism to retain backwards compatibility with fontawesome 4 codes through the use of their "shim" - please see...

https://fontawesome.com/how-to-use/upgrading-from-4

mahagr commented 4 years ago

I agree on dropping those pseudo-elements in CSS.

Additionally, it looks like there are some issues in Grav after this update.

ghost commented 4 years ago

I've now had an opportunity to look at this and it does seem to work quite well. But I still think that we really should not allow overrides by outline for the page settings > fontawesome settings. The reason for this is that a particle may be inherited from one outline to another and therefore it's possible that selecting "fab" icons for a particle would work on one page and not on another if the overrides were used. I really think it should be a global setting (only set in the base outline).

Regards, Mark.

p.s. to implement this suggestion you just need to add this to each field in the yaml:

overrideable: false

mahagr commented 4 years ago

Yes, we already talked about this and I agree. We shouldn't allow the setting to be overridden.

fabio42170 commented 3 years ago

Hello everyone ! Very recently, there was an update on Gantry (Helium) - version 5.4.37. After updating, I noticed something went wrong with the meny item icons. Some icons have been replaced by blinking excalamtive and question marks icons on some pages and not others. This is a link to the problem encountered : [https://www.4u2learn.fr/joomla/forumkunena] Could it be linked to Gantry and the fact that they don't support the new Awesome Font 5 ? Thanks for your answer !

mahagr commented 3 years ago

It is likely caused by a clash between two versions of Font Awesome. Your site attempts to load both order and the new version at the same time.

fabio42170 commented 3 years ago

Hello ! Thanks for answering so quickly. Do you know if there are any parameters I should tweak to get this resolved ? Thanks in advance !

fabio42170 commented 3 years ago

Problem solved ! The "cultprit" was an item in the configuration of the Kunena Forum component in the template. Kunena's template crypsis loads external Awesomefont library and yes, that must be conflicting with the older library. So, just a tweak to get back to normal. https://ibb.co/CBx2jvz

Yet, it is a pity that Gantry does not support the new Awesomefont library ! When will that happen ? Thanks again !

N8Solutions commented 3 years ago

Not to throw a wrench in the works, but the Alpha release of FA6 is already available. https://fontawesome.com/6

I think it would be a good idea to start thinking about integrating FA6 in to a future release of Gantry 5.

fabio42170 commented 3 years ago

I cannot bur agree with this. High time Gantry moved on away from deprecated libraries !

mahagr commented 3 years ago

FA5 will be supported in Gantry 5.5

lipatovroman commented 3 years ago

FA5 will be supported in Gantry 5.5

Hello! Is it possible to include in Gantry 5.5 full version of Font Awesome Free set? I mean all 1,609 Icons. And when Gantry 5.5 will be released? Thanks.

mahagr commented 3 years ago

Looks like we currently have 1598 icons. Looks like a few were added since we did the update.

lipatovroman commented 3 years ago

since we did the update

You already released Gantry 5.5? If yes, I don't see it in Joomla update section.

mahagr commented 3 years ago

It has not been released yet. We're testing it and fixing the bugs that are being found.

fseesink commented 3 years ago

Any update on this by any chance, as in any estimate when Gantry 5.5 will be released?

I ran into the fact something as simple as the Discord icon, using fa fa-discord fa-fw--similar to how the GitHub, Twitter, and LinkedIn icons are set--does NOT show on the site itself. What is strange is that it DOES show when you set it up in the Social particle of the Base Outline. So guessing that's somehow referencing things differently.

(Mind you, I have not tried doing any of the things mentioned in this thread like what @marktaylor46 suggested. I've tried to use Grav with Gantry "as is" purely via the Web UI/Admin tool, mostly as I'd like to see how far someone could go without having to dig under the hood.)

Looks like all of this seems to fall back on that Gantry 5 has yet to support FontAwesome v5, which originally came out in early 2018 if I understand things correctly. (And FA v6 is already in Beta to look at their site.)

mahagr commented 3 years ago

@fseesink Please test the Gantry 5.5 build yourself (in a test site) and report back how it went. We are currently ironing out bugs and the more testing we can get, the faster the release will be out.

fire2 commented 2 years ago

I guess it's time to create a new issue to add support for Fontawesome 6, now that it's released?

mahagr commented 2 years ago

Geez, let's hope it doesn't change the icons again.

N8Solutions commented 2 years ago

I guess it's time to create a new issue to add support for Fontawesome 6, now that it's released?

Glad you posted this. I had received their email a few days before you posted your comment and got busy and forgot to comment here.

mahagr commented 2 years ago

Please just open a new issue. I would also appreciate if someone else had time to look into this.

fire2 commented 2 years ago

Please just open a new issue. I would also appreciate if someone else had time to look into this.

Created #3016