gantry / gantry5

:rocket: Next Generation Template / Theme Framework
http://gantry.org
1.03k stars 206 forks source link

Bourbon Updates? #2835

Open pplopx opened 3 years ago

pplopx commented 3 years ago

Are there plans to update Bourbon tool set for sass?

Grantry seems to support version 4.27. But the latest Bourbon release is version 7, so pretty much everything is deprecated or is in versions higher than v.5 (with the consequent warnings in log files).

Thanks!

mahagr commented 2 years ago

Good catch, I haven't even looked into updating Bourbon library.

Just a quick question, are the old methods still supported allowing the old themes to keep on working, or do they need to be updated, too?

pplopx commented 2 years ago

I have not had a chance to check it out. I understand that you would have to study the documentation for the functions in use to see the upgrade options. In a quick preview, you only have to make small adjustments for some functions; others seem to disappear.

To test, I use the 'Pixels to Rems' (https://www.bourbon.io/docs/4/#px-to-rem) and 'Tint & Shade' (https://www.bourbon.io/docs/4/#tint-shade) functions. They seem to work, but cause a warning message when compiling css from the Gantry panel (which is hard to see because it disappears immediately).

mahagr commented 2 years ago

I just updated the Bourbon to v4.3.4. It doesn't really change anything but adds the deprecation messages. Next, I need to figure out how many of the removed features are being used.

pplopx commented 2 years ago

Well done, Thank you!

mahagr commented 2 years ago

I will still keep this open as I'm thinking of ways to support both the old and new versions of the library.

pplopx commented 2 years ago

Great!