gantry / gantry5

:rocket: Next Generation Template / Theme Framework
http://gantry.org
1.03k stars 204 forks source link

joomla menu not dropping down if you start at level 2 #2947

Closed ssdprogram closed 2 years ago

ssdprogram commented 2 years ago

Menus stopped dropping down if you start at level 2. if level is set to 1 the menu seems to function correctly if set to 2 then when you hover or click you don't see any menu. I can inspect and see the sub levels in source but not on the screen.

joomla 3.10.3 gantry 5.5.5 helium 5.5.5

mahagr commented 2 years ago

@ssdprogram This one may already have been fixed, please check CI builds in https://gantry.org/downloads#ci-builds (just make sure you pick up Joomla package).

ssdprogram commented 2 years ago

Just installed last nights build, fc05189a4 https://github.com/gantry/gantry5/commit/fc05189a4b9c4393aca2892922258d45217cd49f Still no dropdown menus. :(

On Nov 29, 2021, at 10:49 AM, Matias Griese @.***> wrote:

@ssdprogram https://github.com/ssdprogram This one may already have been fixed, please check CI builds in https://gantry.org/downloads#ci-builds https://gantry.org/downloads#ci-builds (just make sure you pick up Joomla package).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gantry/gantry5/issues/2947#issuecomment-981869656, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEU54RNZ6AID3BDMNUC2TDUOO4K5ANCNFSM5IUPYBUA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rhliberman commented 2 years ago

I have been having this same issue for over a year. A few months ago, I was told by RocketTheme that Gantry was aware of the issue and had resolved it in Release 5. We were excited to get this release, in hopes our issue would finally be resolved. We downloaded Release 5.0, and were disappointed that the issue persists. We just downloaded and installed Gantry 5.5.4. No change!

We have too much time and effort invested in our current site to switch frameworks right now. So we are between a rock and a hard place. Our users are confused, our developers are upset, and management is demanding a resolution. As the Webmaster and senior software engineer, I am so frustrated because I cannot fix it. I have spent countless ours trying every conceivable option I can think of.

Please let me know what you are doing to address this issue, and when we can expect it to be resolved once and for all.

Thanks, Robert L.

ghost commented 2 years ago

Ok this isn't elegant but it's a workaround for you.

  1. Add a class on the menu "block" tab of "mylevel2menu"
  2. Change the settings of you menu to start at level 2 AND set the base item to that level 2 item (ie. whichever the menu item is that is the "parent" of the level 3 items.
  3. Add this CSS code to your custom.scss file:
  4. .mylevel2menu .g-main-nav .g-dropdown, .mylevel2menu .g-main-nav .g-standard .g-dropdown .g-dropdown { opacity: 1; visibility: visible; } .mylevel2menu .g-main-nav .g-dropdown .g-level-2.g-go-back , .mylevel2menu .g-main-nav .g-standard .g-dropdown .g-dropdown .g-level-2.g-go-back { display: none; }

I tried this on Horizon theme - here's how it looks for level 1 onwards.. 2021-12-02_15-49-26

and here's how that same menu looks now if you start the menu at level 2 with base item of "features" menu item. 2021-12-02_16-03-21

To be honest i'd also be tempted to not take this approach anyway and instead create separate menu's (even aliased to the original if you need to).

I hope that helps a little.

Regards, Mark.

p.s. ignore the way I named the menu items they actually wrong since level 1 is the top level and "features" is the level 2 item

mahagr commented 2 years ago

@hexplor This seems to be a CSS issue. The dropdown becomes active, but nothing shows up.

ghost commented 2 years ago

@mahagr It's not just a CSS issue. Typically level 1 is top level 2 shows in dropdown and then level 3 slides left. This is the behaviour that seems to be adopted even though the action types should actually all move up a level if you start at level 2 - so I think something much deeper is going on here in the code.

mahagr commented 2 years ago

Could be. Anyway, this issue affects all themes on all CMSes.

ghost commented 2 years ago

It does - which is why I think it's core G5 rather than theme related - and I'm pretty sure it's not just CSS too.

rhliberman commented 2 years ago

I've tried different templates with the same result

rhliberman commented 2 years ago

So is anybody going to fix this?

mahagr commented 2 years ago

Should be fixed in the latest CI builds at https://gantry.org/downloads#ci-builds, please test!

ghost commented 2 years ago

Not fixed "undefined offset 0" Snag_8e4320

ssdprogram commented 2 years ago

Why was this just closed?

I tested and noted that nightly build still didn't fix. I just downloaded nightly builds again and tested. Still no drop down for menus starting at level 2... Marktaylor46 posted still not working.

@mahgr This still is not resolved.....

ghost commented 2 years ago

@mahagr only fixed this 43 minutes ago and the latest CI build is 6 hours old - so give it half an hour and the build will be updated.

mahagr commented 2 years ago

CI builds were just updated.

ghost commented 2 years ago

Confirmed - I just downloaded the latest released CI and I'm afraid that does not fix the issue - still the same "undefined offset 0"

ssdprogram commented 2 years ago

I just tried also and the submenu item is still hidden :(

version 5.5.7-dev-1ddb3968d

mahagr commented 2 years ago

Which theme are you using @ssdprogram ? Maybe it overrides menu particle?

mahagr commented 2 years ago

Oh, also try the new build, there are two similar issues here. Another one was just fixed and the CI build should come out shortly.

ghost commented 2 years ago

Works for me now :)

ssdprogram commented 2 years ago

Using Hydrogen theme. Just downloaded updated version and unfortunately it still doesn’t show drop down menus. :(

On Dec 15, 2021, at 12:30 AM, Matias Griese @.***> wrote:

Which theme are you using @ssdprogram https://github.com/ssdprogram ? Maybe it overrides menu particle?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gantry/gantry5/issues/2947#issuecomment-994421278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEU54VBIX2DIYKDOXHIHW3URA72HANCNFSM5IUPYBUA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ssdprogram commented 2 years ago

My bad. Sorry, cleared cache and verified both gantry and hydrogen had latest package. It is working!!!!

Thanks!!!

On Dec 15, 2021, at 6:09 AM, Craig Curtis @.***> wrote:

Using Hydrogen theme. Just downloaded updated version and unfortunately it still doesn’t show drop down menus. :(

On Dec 15, 2021, at 12:30 AM, Matias Griese @. @.>> wrote:

Which theme are you using @ssdprogram https://github.com/ssdprogram ? Maybe it overrides menu particle?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gantry/gantry5/issues/2947#issuecomment-994421278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGEU54VBIX2DIYKDOXHIHW3URA72HANCNFSM5IUPYBUA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rhliberman commented 2 years ago

Preliminary testing indicates that it appears to be resolved. I am cautiously optimistic - THANKS!