gantry / gantry5

:rocket: Next Generation Template / Theme Framework
http://gantry.org
1.04k stars 204 forks source link

Ganrty dont work in Development mode, PHP 8.1 and 8.2 #3185

Open SamAleev opened 1 year ago

SamAleev commented 1 year ago

When switching to Development mode, the site crashes (screenshot 1 and 3). When switching to Production mode, the site is working, but an error appears (screenshot 2 and 4). These errors occur when switching to PHP 8.1 and 8.2, everything works correctly on PHP 8.0

Joomla 4.3.4 Gantry 5.5.16 Gemini 1.5

4 3 2 1

When using the Helium theme, the error is repeated

tonamphong commented 1 year ago

Try CI builds https://gantry.org/downloads#ci-builds I'm working mainly with Development mode but didn't get any error.

N8Solutions commented 1 year ago

@SamAleev Since this is about the Gemini template, you should close this and open a ticket in the Rocket Theme support forum for the Gemini Template. https://rockettheme.com/forum/joomla-template-gemini

With that said, I am using Gantry 5 templates on Joomla 4 and PHP v8.1 with no issues in Development or Production mode.

When using PHP v8.2 with the Helium template, and Joomla 4 error reporting set to Maximum I only receive the following error in Production mode:

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /var/www/vhosts/example.com/httpdocs/libraries/f0f/less/less.php on line 2428

In Development mode with PHP v8.2 no issues are reported, not even with error reporting set to maximum.

Again, open a ticket in the support forum for Gemini, and try the CI builds as suggested.

N8Solutions commented 1 year ago

@hexplor I installed the CI build. The error message I mentioned above when using PHP v8.2 and Production mode is gone.

However, I did find a styling issue for the login page that looks like this.

This is Joomla v4.3.4 and the current Gantry 5 Joomla CI builds as of this date.

image

@SamAleev if the errors you are dealing with persist after installing the CI builds, I'd recommend you open a ticket for the Gemini template using the link I provided to you above.

hexplor commented 1 year ago

@hexplor I installed the CI build. The error message I mentioned above when using PHP v8.2 and Production mode is gone.

However, I did find a styling issue for the login page that looks like this.

This is Joomla v4.3.4 and the current Gantry 5 Joomla CI builds as of this date.

image

@SamAleev if the errors you are dealing with persist after installing the CI builds, I'd recommend you open a ticket for the Gemini template using the link I provided to you above.

Thank you! I'm going to fix that. Will let you know.

tonamphong commented 1 year ago

@hexplor Could you please take a look this case https://github.com/gantry/gantry5/issues/3144 ?

hexplor commented 1 year ago

@hexplor I installed the CI build. The error message I mentioned above when using PHP v8.2 and Production mode is gone.

However, I did find a styling issue for the login page that looks like this.

This is Joomla v4.3.4 and the current Gantry 5 Joomla CI builds as of this date.

image

@SamAleev if the errors you are dealing with persist after installing the CI builds, I'd recommend you open a ticket for the Gemini template using the link I provided to you above.

Hey @N8Solutions, can you help me recreate that bug? What subpage is that, what module position etc..

N8Solutions commented 1 year ago

@hexplor I used the Rocket Launcher I had for helium (helium-5.5.15-rocketlauncher_j4.1.5), and updated it from there.

This is the login page menu link. image

This Joomla instance has since been updated to the latest version of Joomla and is using the CI build from 3 weeks ago. I checked earlier today and didn't see a more recent version.

Please let me know if you have further questions.

N8Solutions commented 1 year ago

@hexplor I put up another test site just for this as I had done some other things with it. So the new test site is https://gantry5heliumj4.n8solutions.org/login, and the only thing extra I did was to add the "login" & "register" menu items. You'll see the same thing exists on the register page as well.

I believe the issue is associated with the padding attributes for the btn class that is added to the elements which is a styling issue related to Bootstrap due to Joomla 4 using Bootstrap 5.

I hope this information helps!

P.S. - once you're done looking at it, please let me know, so I can take the site down.

N8Solutions commented 1 year ago

@hexplor Since we're looking at possible issues with Bootstrap here. I thought I'd mention that Joomla 5 now uses Bootstrap 5.3.2 so you can take that into consideration when applying the styling fixes because I'm sure it will affect more themes than just Helium.

https://www.joomla.org/announcements/release-news/5900-joomla-5-0-and-joomla-4-4-are-here.html

hexplor commented 1 year ago

Yeah, Already played with Joomla 5. Committed fixes for login buttons. Please check now. It should apply to Joomla 5 as well.

N8Solutions commented 1 year ago

@hexplor The changes for the login page worked! Thank you for that! There is still an issue with the "Register" page. You can see here. https://gantry5heliumj4.n8solutions.org/register

hexplor commented 1 year ago

@N8Solutions fixed. A new build should be available in the next few minutes.

N8Solutions commented 1 year ago

@N8Solutions fixed. A new build should be available in the next few minutes.

Just got home and checked this @hexplor. The fix for the "Register" page on Helium worked.

I did a check using the same site with Hydrogen (its now the default template for the same site) and it has some styling issues on the same pages. The area directly around the Font Awesome Eye icon and the "Web Authentication" button is "Transparent". If you inspect the pages, you'll see the Bootstrap 5 btn class has transparent set for the background-color and border attributes. The text "Web Authentication" doesn't line up with the FA icon.

Also, if you notice on the "Login" page, the "Login" button at the bottom lines up perfectly with the fields for the username and password. However, on the "Register", "Forgot Password", "Forgot Username" pages, the "Submit" button is off to the left of the those fields where in Helium it lines up perfectly.

hexplor commented 1 year ago

Ok. next build should be ready within minutes with all fixes included.

N8Solutions commented 1 year ago

Ok. next build should be ready within minutes with all fixes included.

Great, thank you @hexplor! I'll check it out as soon as I can.

I'm guessing that similar changes will need to be made to all the Rocket Theme templates as well, correct? If so, is there a time frame of when those will be updated?

N8Solutions commented 1 year ago

@hexplor that fixed the styling issue for the area directly around the Font Awesome Eye icon and the "Web Authentication" button is no longer "Transparent". However, the "submit" buttons at the bottom still do not line up.

Also, if you notice on the "Login" page, the "Login" button at the bottom lines up perfectly with the fields for the username and password. However, on the "Register", "Forgot Password", "Forgot Username" pages, the "Submit" button is off to the left of the those fields where in Helium it lines up perfectly.

Is this intended or should it be fixed?

N8Solutions commented 1 year ago

Good morning @hexplor,

Just checking the test site I have and the styling issue still exists in Hydrogen for the...

It's just the button at the bottom of the form as it doesn't line up and sits to the left of the fields where on the Login Page everything lines up perfectly.

Thank you for all the work you are doing!