gantry / gantry5

:rocket: Next Generation Template / Theme Framework
http://gantry.org
1.03k stars 205 forks source link

Extendable YAML and Twig files #904

Open w00fz opened 8 years ago

w00fz commented 8 years ago

This is to remind, consolidate and group together a couple issues we have open that should get addressed contemporary. [#751 #782]

These are both important implementations that need to be addressed.

w00fz commented 8 years ago

This also relates to #306.

We really do need this. :)

nicutor commented 8 years ago

+1

mahagr commented 8 years ago

I've been working on YAML part, but its not going to make it into 5.3.0 as it still has some bugs in it.

AmibeWebsites commented 7 years ago

Where can I see how this works? Thanks...

mahagr commented 7 years ago

Heh, it is documented in Grav: https://learn.getgrav.org/forms/blueprints/advanced-features

N8Solutions commented 5 years ago

@mahagr & @w00fz I know this has been discussed quite a bit over the years and its obviously not an easy one to fix. Is there any progress in being able to do this, specifically concerning the /gantry/theme.yaml file?

I have really been looking forward to this coming to fruition for quite some time now. I got to thinking about it again due to GDPR as well as recently with issue #2451.

What I'm running in to since GDPR is some sites where customers do not want to use Google Fonts and would prefer to load the fonts locally. However, making that change in the /gantry/theme.yaml file means that every time I update Gantry 5 I have to go in and manually update the /gantry/theme.yaml file.

I also have a couple of sites where I have been loading the fonts from Page Settings using Google Fonts where the customers are not so concerned about GDPR and Google Fonts. However, one of the fonts being used is not rendering properly when the site is viewed in Greek so I had to load it locally via /gantry/theme.yaml. Again, I have to update that file manually whenever I update Gantry 5. This creates more work on my end.

I also know that this was brought up by @alisamii when he opened issue #782 on Sept. 2nd, 2015.

What is the likelihood of this particular issue getting some more attention in 2019?

mahagr commented 2 years ago

@N8Solutions

I've finally implemented a way to use your own custom/gantry/theme.yaml file. I chose to go for a simple solution: if the file exists, it will be used instead of the default file. So if you override the file (or any other file), it is a good idea to check now and then if it has changed. Generally, themes have been very stable and most changes are between larger versions: 5.4 -> 5.5 -> 5.6...

Please check if it now works for you in CI build: https://gantry.org/downloads#ci-builds

PS. make sure you pick the correct file for your CMS.

N8Solutions commented 2 years ago

Thank you @mahagr! I'll check this out as soon as I get a chance.