gantsign / ansible-role-oh-my-zsh

Ansible role for installing and configuring oh-my-zsh
https://galaxy.ansible.com/gantsign/oh-my-zsh
MIT License
165 stars 41 forks source link

Allow conditional install per user #108

Closed nekeal closed 4 years ago

nekeal commented 4 years ago

Variable users is often used in other roles, mainly for creating users. Such roles allow specifying a default shell for a user. However, this role forces having zsh for each user specified in users list. My PR allows setting install_oh_my_zsh to false to omit particular users when installing oh-my-zsh.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

freemanjp commented 4 years ago

@nekeal thank you for your pull request, sorry it took me so long to merge it. I've made a few alterations to make it more consistent with the existing role variables and to change the default for wether Oh My Zsh should be installed for all the specified users. You can find this change in version 2.3.0 of this role.