gantsign / ansible-role-oh-my-zsh

Ansible role for installing and configuring oh-my-zsh
https://galaxy.ansible.com/gantsign/oh-my-zsh
MIT License
165 stars 41 forks source link

allow to specify custom configuration #114

Closed n0emis closed 3 years ago

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

tutunak commented 3 years ago

@n0emis do you plan to fix it?

n0emis commented 3 years ago

@n0emis do you plan to fix it?

Plan to fix what?

tutunak commented 3 years ago

@n0emis test failed.

n0emis commented 3 years ago

That error seems like something I did not cause. Could you re-run the tests please?

tutunak commented 3 years ago

Unfortunately not, maybe @freemanjp could help us.

freemanjp commented 3 years ago

@n0emis thanks for the pull request, but unfortunately I won't be accepting this change. In my experience, once you need to customize the ~/.zshrc it quickly becomes difficult to maintain without a Zsh Plugin manager such as Antigen. Which is why I created an Ansible role for Antigen (gantsign.antigen), with that you can install Oh My Zsh and configure it with all the custom configuration you need.