search

gantsign / ansible-role-oh-my-zsh

Ansible role for installing and configuring oh-my-zsh
https://galaxy.ansible.com/gantsign/oh-my-zsh
MIT License
165 stars 41 forks source link

Feature Request: Custom plugin installation #117

Closed oncleben31 closed 3 years ago

oncleben31 commented 3 years ago

Hello what do you think about adding a way to install custom plugins ?

Generally it means:

oncleben31 commented 3 years ago

A quick and dirty implementation prototype: https://github.com/oncleben31/infra/commit/8da46ae2edcfe1e9d0c846576263dccb19380db8

If you are interested, I can work on a PR.

freemanjp commented 3 years ago

@oncleben31 I appreciate the suggestion, but once you start installing custom plugins, you're better off using a Zsh plugin manager such as Antigen, which his why I created an Ansible role for Antigen gantsign.antigen. You can use it to install Oh My Zsh and custom plugins. I suggest you check it out.

oncleben31 commented 3 years ago

I didn't know Antigen before this issue. I gave a try and honestly I'm a bit frustrated with this approach despite being very promising.

My previous approach based on ansible-role-oh-my-zsh and the one base on gantsign.antigen where in conflict. And trying to start from scratch I have difficulties to have a a clean installation (still have issues with theme).

And what about maintenance of the Ansible Role and Antigen repo. The fact there is no recent release make me hesitate to deepdive in this approach.

freemanjp commented 3 years ago

There's a bunch of other Zsh plugin managers (see https://github.com/unixorn/awesome-zsh-plugins#installation), most of which have more features and faster loading times than Oh My Zsh's plugin handling. Honestly, if I were starting from scratch, I'd probably use zplug (I don't know if there are Ansible roles for it), but Antigen has been working well for me for years.

If you still want to use Oh My Zsh for plugin management you're welcome to fork this role (that's part of the reason it's MIT licensed). I'll probably deprecate this role at some point, I've not used it in years, the only reason I haven't is it's still widely used and requires little maintenance.

oncleben31 commented 3 years ago

Thank you for the discussion. I will keep my quick @ dirty custom plugin management in Oh My Zsh. And look for implementing alternatives in the future.