Made the package names of the git and zsh package variable

gantsign / ansible-role-oh-my-zsh

Ansible role for installing and configuring oh-my-zsh

https://galaxy.ansible.com/gantsign/oh-my-zsh

MIT License

165 stars 41 forks source link

Made the package names of the git and zsh package variable #120

Closed kagehisa closed 2 years ago

kagehisa commented 3 years ago

Since pkg names can differ on some systems ( e.g. between OpenSUSE and SLES) it would be benefitial to have the package names as a variable and allow the user to change theses names if needed. With the changes in this pull request the provided package names are used as a default value for the newly introduced variables git_pkg and zsh_pkg. THey don't interfere with the current behaviour of the role and are only needed when the user has a target system with different package names for these two packages.

CLAassistant commented 3 years ago

All committers have signed the CLA.

freemanjp commented 2 years ago

@kagehisa, sorry this PR appears to have fallen through the cracks due to the transition from Travis CI to GitHub Actions. Rather than merging your change, I've merged a similar change with a more generic approach (#122). I've also not included this in the README.md as I don't think this is something most users should be configuring (in general it's better to enhance the role to handle different Linux distributions instead). However, you can find the change in version 2.4.0 if this role.