gantsign / ansible-role-oh-my-zsh

Ansible role for installing and configuring oh-my-zsh
https://galaxy.ansible.com/gantsign/oh-my-zsh
MIT License
165 stars 41 forks source link

Updated install.yml #93

Closed dynax60 closed 4 years ago

dynax60 commented 4 years ago
CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

freemanjp commented 4 years ago

Hi @dynax60, thanks for the pull request. Unfortunately, it's currently written to support setting the group ownership of the files when the default group doesn't match the user name (it was changed in https://github.com/gantsign/ansible-role-oh-my-zsh/commit/02c7f1684dba4d2cc1530bca802f69ca925ca576 for that purpose).

What Ansible needs is a filter to get the group for a specified user e.g.:

group: '{{ item.username | group_for_user }}'

As it stands you either have to choose between setting the correct group or problems running the commands as non-root.

Given it's going to be broken for some users either way, I'm going to leave it the way it is (rather than breaking existing users) until Ansible provides a solution.

You're welcome to fork the role for your use-case, sorry I can't be more help.