gantsign / ansible_role_antigen

Ansible role for installing the Antigen and using it to configure Zsh
https://galaxy.ansible.com/gantsign/antigen
MIT License
27 stars 16 forks source link

no matches found: /home/chengjianhua/.antigen-etc/bundle.d/*.zsh #50

Closed chengjianhua closed 2 years ago

chengjianhua commented 2 years ago

After performing ansible playbook which configures the role like below:

    - role: gantsign.antigen
      users:
        - username: "{{ ansible_user }}"
          antigen_libraries:
            - name: oh-my-zsh

Then I login into my remote host, I encountered the following errors:

/home/chengjianhua/.antigenrc:14: no matches found: /home/chengjianhua/.antigen-etc/bundle.d/*.zsh

It seems that the empty bundle list caused glob expression to fail: https://github.com/gantsign/ansible_role_antigen/blob/2e3f5719e852de66458eeb4f9ec67e2385173303/templates/antigenrc.j2#L12

chengjianhua commented 2 years ago

@freemanjp Could you take this a look, please 🙏

freemanjp commented 2 years ago

Hi, @chengjianhua thanks for reporting this issue and sorry for the late reply (my day job hasn't left much time for my OSS projects recently). I never anticipated anyone would use the role with the antigen_libraries without also specifying some antigen_bundles. Specifying at least one bundle e.g. git should work around the issue for now. I doubt I'll have time for a proper fix until next year.

freemanjp commented 2 years ago

@chengjianhua sorry it took some time, the fix is in version 1.4.2 of this role.

chengjianhua commented 2 years ago

@chengjianhua sorry it took some time, the fix is in version 1.4.2 of this role.

@freemanjp Appreciate your great work 👍