search

gantsign / kotlin-maven-plugin-tools

Metadata extractor for Maven plugins written in Kotlin.
Apache License 2.0
16 stars 6 forks source link

Extractor Fails with maven 3.9.0 #403

Open jangalinski opened 1 year ago

jangalinski commented 1 year ago

I tried to run this dependency in my mavan-plugin-plugin 3.9.0 project and get the following build: error

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-plugin-plugin:3.9.0:descriptor (default-descriptor) on project ...: 
The API of the mojo scanner is not compatible with this plugin version. 
Please check the plugin dependencies configured in the POM and ensure the versions match.: 
Receiver class com.github.gantsign.maven.tools.plugin.extractor.kotlin.KotlinMojoDescriptorExtractor does not define 
or inherit an implementation of the 
resolved method 'abstract org.apache.maven.tools.plugin.extractor.GroupKey getGroupKey()' 
of interface org.apache.maven.tools.plugin.extractor.MojoDescriptorExtractor. -> [Help 1]
marcelmay commented 6 months ago

@freemanjp , any chance to get an updated release for Maven 3.9.x? Is there anything we can help with (Maven 3.9 integration test PR, ...)?

As mentioned above, Maven Plugin Tools release 3.7.0 introduced a breaking change in MPLUGIN-378) of new method [MojoDescriptorExtractor#getGroupKey()](https://maven.apache.org/plugin-tools/maven-plugin-tools-api/apidocs/org/apache/maven/tools/plugin/extractor/MojoDescriptorExtractor.html#getGroupKey())

bobjana commented 5 months ago

I tried to apply a fix to overcome this issue. Upgraded all libraries and implemented new interface. Currently failing on integration tests for help-mojo. So a bit stuck, if someone wants to take the patch forward and submit a pull reques. Upgrade_dependencies_and_implement_new_interface.patch