gantsign / ktlint-maven-plugin

Maven plugin for ktlint the Kotlin linter
http://gantsign.com/ktlint-maven-plugin/
MIT License
61 stars 17 forks source link

Remind Java 16 users to add extra JVM arg #544

Closed Goooler closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (bd24382) 87.98% compared to head (9f7679b) 87.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #544 +/- ## ========================================= Coverage 87.98% 87.98% Complexity 84 84 ========================================= Files 16 16 Lines 566 566 Branches 62 62 ========================================= Hits 498 498 Misses 25 25 Partials 43 43 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gantsign). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gantsign)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

freemanjp commented 1 year ago

@Goooler thanks for your PR. I gave this quite a bit of thought when I added the comment relating to strong encapsulation. Java 16 had been out of support for nearly a year when the comment was added (which I think says something about the number of users of non-LTS Java releases), and it's been out of support for nearly a year and a half now. While you're right that Java 16 is the first affected version, I expect very few projects will be adding this plugin to a Java 16 project at this point (or upgrading a pre-16 project to Java 16). I figured more people would be served by explicitly naming the 17 LTS release than by saying 16 and higher. If you feel strongly that 16 should be mentioned, we can compromise by mentioning it in the description (in addition the Java 17) and by leaving the heading the same.

Goooler commented 1 year ago

Either way, I was guessing this is intended, thanks for your explanation.