search

gantsign / ktlint-maven-plugin

Maven plugin for ktlint the Kotlin linter
http://gantsign.com/ktlint-maven-plugin/
MIT License
61 stars 17 forks source link

Bump Ktlint to 1.1.1 #580

Closed Goooler closed 7 months ago

Goooler commented 11 months ago

https://github.com/pinterest/ktlint/releases/tag/1.1.1

Follow up #574.

Goooler commented 11 months ago

Not sure why this update hasen't been sent by @dependabot automatically, maybe we can use @renovate-bot to replace it.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.66%. Comparing base (8765035) to head (66d81ca). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #580 +/- ## ============================================ - Coverage 88.16% 86.66% -1.50% Complexity 91 91 ============================================ Files 17 17 Lines 625 555 -70 Branches 59 59 ============================================ - Hits 551 481 -70 Misses 35 35 Partials 39 39 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nilsschmidthamburg commented 8 months ago

The commit itself looks good. It seems the pipeline failed because some service was temporarly not available. @see "curl: (22) The requested URL returned error: 503 Service Temporarily Unavailable"

Could somebody with matching rights retrigger the job to see if it will run through now.

We would be very happy to see a version of ktlint-maven-plugin supporting kltint 1.1.1 in the near future. Thanks for the great work!

sanyarnd commented 7 months ago

@gantsign any chance to update the plugin?

freemanjp commented 7 months ago

@Goooler thanks for the PR, sorry for the delay. You can find your fix in version 3.1.1 of this plugin (it may take a few hours for it to be downloadable from Maven Central),

Goooler commented 7 months ago

It would be better to follow the latest ktlint version 1.2.1, and draft a new release.

Goooler commented 7 months ago

Not sure why @dependabot hasn't sent ktlint updates, maybe we can replace it with @renovate-bot.