row_win.cc fails to build under x86 vs9/10

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Build row_win.cc using visual studio 2008 or 2010
2.
3.

NV12ToARGBRow_AVX2 and NV21ToARGBRow_AVX2 are missing HAS_* ifdef protection. 
Attached patch should fix the issue.

      ..\third_party\libyuv\source\row_win.cc(1706): warning C4405: 'ymm0' : identifier is reserved word [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1707): warning C4405: 'ymm3' : identifier is reserved word [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): warning C4405: 'ymm0' : identifier is reserved word [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): warning C4405: 'ymm2' : identifier is reserved word [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1734): warning C4405: 'ymm0' : identifier is reserved word [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1735): warning C4405: 'ymm3' : identifier is reserved word [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): warning C4405: 'ymm0' : identifier is reserved word [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): warning C4405: 'ymm2' : identifier is reserved word [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1706): warning C4405: 'ymm0' : identifier is reserved word [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1707): warning C4405: 'ymm3' : identifier is reserved word [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): warning C4405: 'ymm0' : identifier is reserved word [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): warning C4405: 'ymm2' : identifier is reserved word [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1734): warning C4405: 'ymm0' : identifier is reserved word [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1735): warning C4405: 'ymm3' : identifier is reserved word [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): warning C4405: 'ymm0' : identifier is reserved word [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): warning C4405: 'ymm2' : identifier is reserved word [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1703): error C2415: improper operand type [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1706): error C2400: inline assembler syntax error in 'opcode'; found 'ymm0' [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1706): error C2415: improper operand type [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1707): error C2415: improper operand type [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1707): error C2400: inline assembler syntax error in 'opcode'; found 'ymm3' [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): error C2415: improper operand type [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): error C2400: inline assembler syntax error in 'opcode'; found 'ymm0' [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): error C2400: inline assembler syntax error in 'opcode'; found 'ymm2' [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1731): error C2415: improper operand type [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1734): error C2400: inline assembler syntax error in 'opcode'; found 'ymm0' [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1734): error C2415: improper operand type [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1735): error C2415: improper operand type [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1735): error C2400: inline assembler syntax error in 'opcode'; found 'ymm3' [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): error C2415: improper operand type [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): error C2400: inline assembler syntax error in 'opcode'; found 'ymm0' [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): error C2400: inline assembler syntax error in 'opcode'; found 'ymm2' [.build-x86-win32-vs10\vpxdec.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1703): error C2415: improper operand type [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1706): error C2400: inline assembler syntax error in 'opcode'; found 'ymm0' [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1706): error C2415: improper operand type [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1707): error C2415: improper operand type [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1707): error C2400: inline assembler syntax error in 'opcode'; found 'ymm3' [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): error C2415: improper operand type [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): error C2400: inline assembler syntax error in 'opcode'; found 'ymm0' [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1708): error C2400: inline assembler syntax error in 'opcode'; found 'ymm2' [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1731): error C2415: improper operand type [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1734): error C2400: inline assembler syntax error in 'opcode'; found 'ymm0' [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1734): error C2415: improper operand type [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1735): error C2415: improper operand type [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1735): error C2400: inline assembler syntax error in 'opcode'; found 'ymm3' [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): error C2415: improper operand type [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): error C2400: inline assembler syntax error in 'opcode'; found 'ymm0' [.build-x86-win32-vs10\vpxenc.vcxproj]
         ..\third_party\libyuv\source\row_win.cc(1736): error C2400: inline assembler syntax error in 'opcode'; found 'ymm2' [.build-x86-win32-vs10\vpxenc.vcxproj]

Original issue reported on code.google.com by jz...@google.com on 6 Mar 2015 at 7:11

Attachments:

• add_missing_msvs_avx2_ifdefs.diff

[GoogleCodeExporter]

confirmed.
to build with vs2010:
python build\gyp_chromium -fninja -G msvs_version=2010 --depth=. libyuv_test.gyp
ninja -C out\Debug

Original comment by fbarch...@google.com on 6 Mar 2015 at 6:57

• Changed state: Accepted

[GoogleCodeExporter]

fixing that, there is still a test error
c:\src\libyuv2\trunk\unit_test\convert_test.cc(1367) : error C3861: 'lrintf': 
identifier not found

Original comment by fbarch...@google.com on 6 Mar 2015 at 6:59

[GoogleCodeExporter]

Original comment by fbarch...@google.com on 7 Mar 2015 at 3:59

• Changed state: Fixed