build: Add local lib path for darwin and windows

ganzziani / xscopes-qt

XScopes PC Interface

74 stars 39 forks source link

build: Add local lib path for darwin and windows #37

Closed rzr closed 6 years ago

rzr commented 6 years ago

In longer term it would make sense to remove those libs and use system's ones like linux

Change-Id: I6399b9715b245c2cc11828a0f3bb8f825f72c0c3 Bug: https://github.com/ganzziani/xscopes-qt/issues/36 Signed-off-by: Philippe Coval rzr@users.sf.net

HomeACcessoryKid commented 6 years ago

this does not work since the line in XprotolabInterface.pro line 45 still contains the invocation for unix and will give the error described in #30

rzr commented 6 years ago

Arent you using cmake at all ?

I am septical about linking linux binaries to darwin ones :)

HomeACcessoryKid commented 6 years ago

Message 1: it works with your proposal

Message 2: the instructions I found and that seem to work for me are like this:

2) install qt and libusb: brew install qt libusb
3) get xscopes' sources: git clone https://github.com/ganzziani/xscopes-qt.git
4) change into the cloned dir: cd xscopes-qt
5) export PATH="/usr/local/opt/qt/bin:$PATH"
6) compile: qmake && make

So, no, that does not include cmake

like I said, I do not know how all these make flavours work. I trust that your proposals will have improved everybody's experience. according to my testing it worked for me

Thanks for your help

rzr commented 6 years ago

You're welcome ! once merged I propose to tag a new release.

I am granted to merge this is anyone against this ?

@HomeACcessoryKid may I suggest you to edit this wiki page: https://github.com/ganzziani/xscopes-qt/wiki

rzr commented 6 years ago

Is anyone against merging this ?

cc: @ganzziani