ganzziani / xscopes-qt

XScopes PC Interface
74 stars 39 forks source link

Add current mouse position in Volts #45

Closed brunetton closed 3 years ago

brunetton commented 4 years ago

Hi, first of all, thanks for making all of this open source, this is much appreciated !

The goal of this PR is to add a text zone on the bottom of the oscilloscope screen to indicate actual mouse cursor's voltage. I needed it to follow some curves with mouse pointer and having precise voltage measurements.

This branch consists of two distinct commits. I tried to minimize changes made to code, not to alter the "spirit" of the code and keep it "consistent". Typically, I resisted to the temptation of making it more close to the MVC paradigm.

First commit

Second commit

More to-do ?

In the same spirit, we could also indicate cursor's current "time", but I didn't needed it, as I can place vertical markers.

rzr commented 4 years ago

this looks good to me, any one against merging this ? without negative feedback i can merge this change in a couple of weeks remind me to merge and update debian package regards