gaogaotiantian / viztracer

VizTracer is a low-overhead logging/debugging/profiling tool that can trace and visualize your python code execution.
https://viztracer.readthedocs.io/
Apache License 2.0
4.94k stars 369 forks source link

jupyter integration not working properly on remote jupyter lab #427

Open auderson opened 5 months ago

auderson commented 5 months ago

The "VizTracer Report" button will not work if user is using remote jupyter, because the code is running on the server side. However user can still open the page manully from his local browser.

https://github.com/gaogaotiantian/viztracer/blob/9f17472c1ab527625bd5ba145318852be1ef4d01/src/viztracer/cellmagic.py#L53-L63

gaogaotiantian commented 5 months ago

When a webserver is hosted remotely, you can open a local browser and access it? That sounds a bit off. I don't use jupyter personally so jupyter has never been the first class citizen for viztracer. I don't have any solutions by hand even though I can understand the issue.

auderson commented 5 months ago

Well…By saying remote & local I actually mean the Ubuntu server of my company & my office desktop, they’re in the same network.

I don't use jupyter personally so jupyter has never been the first class citizen for viztracer.

No big deal, the VizViewer CLI is good.

I don't have any solutions by hand even though I can understand the issue.

Yes, this issue is quite easy to understand, but the solution may not be so straightforward.