gaojq / smallproject1

0 stars 0 forks source link

Code Review from Yujia Wang #1

Open YUJIA8 opened 6 years ago

YUJIA8 commented 6 years ago

1, Successfully called the API to download the photos from Ibrahimovich for exactly 21 pictures and each time I run the program, the 21 pictures are all the same as previously. 2, The three steps of mini project1 are not connected as one python file, there are three of them. 3, The readability of the programs are not that clear, even though that is clear for me since I have worked on this project too. 4, Cannot create a video.mp4 file, obviously you didn't call the function in your Video.py, you just defined it. 5, For the Label.py, it comes up with the error which is unexpected indent error. Seems like there is something wrong with your indents. 6, The main call is Asynchronous.

gaojq commented 6 years ago

Did some error correction please check