gaorlov / deserializer

Deserialization of complex API params into objects that can be consumed by an AR model
MIT License
22 stars 3 forks source link

Barebones JSONAPI Deserializer #9

Open chr0n1x opened 4 years ago

chr0n1x commented 4 years ago

Attempts to lay a barebones foundation for the discussion points in #8

chr0n1x commented 4 years ago

@gaorlov Ive also got a few changes to the Gemfile (just moving some things around to the gemspec) and I also tried getting rubocop into this repo. The style fixes are numerous and I feel like they would be out of the scope of this PR even if rubocop has an option to autocorrect.

Let me know if you would like me to push up the changes just for adding rubocop though.

gaorlov commented 4 years ago

I added Travis. Does that allow you to remove the docker and make files?

chr0n1x commented 4 years ago

@gaorlov not exactly. The travis config that you added will check the PR itself. But I run & write tests locally, so that's the point of the docker & make files.

That being said, if you would prefer to not have them in the repository at all I can remove, just say so 😃

gaorlov commented 4 years ago

Not everyone has docker and make available on their systems (windows users can't spin up an alpine image for example). Ideally this repo would have as small a technology footprint as possible.

chr0n1x commented 4 years ago

@gaorlov fair point, done 😄

gaorlov commented 4 years ago

Can you pull in master so that we can see what travis does against your changes?

chr0n1x commented 4 years ago

@gaorlov done