Open chr0n1x opened 4 years ago
@gaorlov Ive also got a few changes to the Gemfile (just moving some things around to the gemspec) and I also tried getting rubocop into this repo. The style fixes are numerous and I feel like they would be out of the scope of this PR even if rubocop has an option to autocorrect.
Let me know if you would like me to push up the changes just for adding rubocop though.
I added Travis. Does that allow you to remove the docker and make files?
@gaorlov not exactly. The travis config that you added will check the PR itself. But I run & write tests locally, so that's the point of the docker & make files.
That being said, if you would prefer to not have them in the repository at all I can remove, just say so 😃
Not everyone has docker and make available on their systems (windows users can't spin up an alpine image for example). Ideally this repo would have as small a technology footprint as possible.
@gaorlov fair point, done 😄
Can you pull in master so that we can see what travis does against your changes?
@gaorlov done
Attempts to lay a barebones foundation for the discussion points in #8
yield
block would give users the flexibility of how they want to interpret the top-level attributes in JSONAPI compliant payloadsmake dev
env will drop you into a docker container with the code in/workspace
. And the dir that you're running that command in will have all its contents mounted. This way you can develop on your host while running everything in your docker file