gap-actions / run-pkg-tests

Other
1 stars 4 forks source link

Fix regression for autoloaded packages #22

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

Some packages are autoloaded by GAP during startup. For these, the call to SetPackagePath may fail for a silly reason: GAP compares it to the path of the currently loaded version, and if they differ, prints an error. We give GAP $PWD as path of the package; but in practice, GAP already loaded it from /tmp/gaproot/PackageName. So use that as path instead.

fingolfin commented 2 years ago

Currently being tested by https://github.com/gap-packages/laguna/pull/31 where the bug manifested as was reported by @alex-konovalov

wilfwilson commented 2 years ago

We can temporarily roll back the v2 tag if this is going to take a while a fix.

fingolfin commented 2 years ago

shouldn't take long, just got distracted

fingolfin commented 2 years ago

OK it was trivial after all 😂 I simply was stupid