search

gap-actions / run-pkg-tests

Other
1 stars 4 forks source link

Add `GAP_FLAGS` to list of inputs #24

Closed james-d-mitchell closed 9 months ago

james-d-mitchell commented 1 year ago

I wonder if it would be a good idea to check whether or not the inputs only-needed is true and GAP_FLAGS contains -A would be a good idea. I also haven't tested this at all, I'm not sure how to, hopefully there's some ci here?

james-d-mitchell commented 1 year ago

@fingolfin

wilfwilson commented 1 year ago

Hey @james-d-mitchell, thanks for this.

I'll mention #9 here to make it easy to reference, in which you mention that you'd particularly like this for loading/saving workspaces.

I've looked into this a little bit, and I feel a little bit out of the loop in how all of this actions stuff works right now (haven't looked at it for a long time).

So I'm not sure what the best thing to do is, so that your new GAP_FLAGS option works in the most sensible way (with respect to the other input options, and with respect to the GAP arguments that are already used). Perhaps @fingolfin has some ideas.

As of the current master branch, this workflow already may or may not (depending on the inputs to the workflow) set the GAP command line arguments -l, --quitonbreak, --cover, and -A, as you refer to.

I've put an example of how you could add some very rudimentary CI for this GAP_FLAGS in https://github.com/wilfwilson/run-pkg-tests/commit/ee44353f4a26195d7c16abd8bb5c9d4477b553d5 - hopefully you can see that and cherry-pick it or whatever.

james-d-mitchell commented 9 months ago

Thanks @wilfwilson, if I understand correctly, what I was trying to add in this PR is already implemented, making this superfluous. I'll close the PR that being the case.