search

gap-actions / setup-gap

Other
1 stars 5 forks source link

Convert for use with Cygwin (DO NOT MERGE) #22

Closed wilfwilson closed 2 years ago

wilfwilson commented 3 years ago

The purpose of this PR is to show how it is possible to have a version of this that works with the Cygwin provided by https://github.com/gap-actions/setup-cygwin-for-gap – see #18. This branch is currently being used in https://github.com/gap-packages/io/pull/97 - so you can see how it works (or rather doesn't work) there.

(Note that this is based on the older version of this action that also built the package as well as GAP.)

Some of the steps are the same and can use bash as the shell (downloading the CI scripts). Some of the steps I have only got to work with the cmd shell.

I haven't checked, but I imagine that these steps are not currently passing on the appropriate environment variables to C:\cygwin64\bin\bash.

I don't yet understand this stuff well enough to see how this could be unified with the version that runs on Ubuntu/macOS.

wilfwilson commented 2 years ago

I am closing this pull request in favour of pushing a new branch to the repository called cygwin-v2 (cygwin because it is the branch to use with Cygwin builds; v2 because it should mirror the content of the main branch, which is at v2).

Because there is still no possibility to dynamically set the shell variable in composite actions, I currently see no way of integrating this stuff into the master branch. Hopefully this will be possible one day. But for now, I will keep it separate (and keep the diffs as small as possible).