Just now, for the OrbitalGraphs package, I added digraphs/Digraphs to my GAP_PKGS_TO_CLONE option. Since that is how the repository is capitalised, I thought that the capitalisation might be important.
However, the released version of Digraphs v1.3.1 is the one that ended up getting built and loaded for the tests.
This happened for a few reasons. In this line, where existing version of packages are supposed be deleted before the new one is cloned, digraphs-1.3.1 did not get removed, because $pkg at this point has value Digraphs:
Furthermore, digraphs-1.3.1 got built, but not the newly cloned version of Digraphs, because I had put digraphs (lowercase) into GAP_PKGS_TO_BUILD.
How can we deal with this in a more user-friendly way?
Since there should not be different GAP packages that have the same name except for capitalisation, I think it should be safe to try to do everything in a case-insensitive way.
Just now, for the OrbitalGraphs package, I added
digraphs/Digraphsto myGAP_PKGS_TO_CLONEoption. Since that is how the repository is capitalised, I thought that the capitalisation might be important.However, the released version of Digraphs v1.3.1 is the one that ended up getting built and loaded for the tests.
This happened for a few reasons. In this line, where existing version of packages are supposed be deleted before the new one is cloned,
digraphs-1.3.1did not get removed, because$pkgat this point has valueDigraphs:https://github.com/gap-actions/setup-gap/blob/c7c08ab623994f4c769c623fe05a09f306e69912/action.yml#L100
Furthermore,
digraphs-1.3.1got built, but not the newly cloned version of Digraphs, because I had putdigraphs(lowercase) intoGAP_PKGS_TO_BUILD.How can we deal with this in a more user-friendly way?
Since there should not be different GAP packages that have the same name except for capitalisation, I think it should be safe to try to do everything in a case-insensitive way.