search

gap-actions / setup-gap

Other
1 stars 5 forks source link

GAP_PKGS_TO_BUILD is case sensitive, which causes breakage #43

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

Had to do this recently:

      - uses: gap-actions/setup-gap@v2
        with:
          # WORKAROUND: we have both zeromqinterface and ZeroMQInterface
          # in the list because GAP_PKGS_TO_BUILD is dumb and tries to
          # match packages based on directory names, and here the case
          # changed ...
          GAP_PKGS_TO_BUILD: "io profiling crypting json uuid zeromqinterface ZeroMQInterface"
          GAPBRANCH: ${{ matrix.gap-branch }}

Reason is that we pass the given names directly to BuildPackage.sh, which in turn uses them to match directory names. But these changed (and can change again).

Better would be to use e.g. PackageManager to deal with this cleanly...

ChrisJefferson commented 2 years ago

I was hitting this and made a PR before I noticed this issue -- #44

ChrisJefferson commented 2 years ago

fixed in #44