gap-packages / ClassicalMaximals

Maximal subgroups of classical groups

Other

0 stars 8 forks source link

Set quadratic forms #104

Closed maxhauck closed 2 years ago

maxhauck commented 2 years ago

Modify ConjugateToSesquilinearForm so that the quadratic form is also set at the end.

Checklist for the reviewer

General

[ ] All functions have unit tests

Functions constructing generators of maximal subgroups

[ ] The code which computes and then stores the sizes is correct. To do this one confers to the tables referenced by the code.
[ ] The test suite checks whether all constructed generators are sensible. That is it tests the generators'
- [ ] determinants (and if applicable also the spinor norms are correct), and
- [ ] compatibility with the correct form,
- [ ] DefaultFieldOfMatrixGroup returns the correct field.

Functions assembling the list of all maximal subgroups of a certain group

[ ] The code agrees with the tables in section 8.2 of the book "The Maximal Subgroups of the Low-dimensional Finite Classical Groups".

The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.

codecov[bot] commented 2 years ago

Codecov Report

Merging #104 (d538a92) into main (4ff4a08) will decrease coverage by 0.01%. The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   95.59%   95.58%   -0.02%     
==========================================
  Files          14       14              
  Lines        3227     3237      +10     
==========================================
+ Hits         3085     3094       +9     
- Misses        142      143       +1

Impacted Files	Coverage Δ
gap/Forms.gi	`88.11% <93.33%> (+0.22%)`	:arrow_up:
gap/ReducibleMatrixGroups.gi	`98.47% <100.00%> (-0.02%)`	:arrow_down: