Closed maxhauck closed 2 years ago
Merging #105 (00147fa) into main (4ff4a08) will decrease coverage by
1.93%
. The diff coverage is40.33%
.
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 95.59% 93.66% -1.94%
==========================================
Files 14 14
Lines 3227 3345 +118
==========================================
+ Hits 3085 3133 +48
- Misses 142 212 +70
Impacted Files | Coverage Δ | |
---|---|---|
gap/ClassicalMaximals.gi | 87.21% <9.21%> (-9.58%) |
:arrow_down: |
gap/ExtraspecialNormalizerMatrixGroups.gi | 96.82% <94.87%> (+0.07%) |
:arrow_up: |
gap/ClassicalMaximals.gd | 100.00% <100.00%> (ø) |
As always, tests for the main & generic function in
ClassicalMaximals.gi
will be added later when case O is done.Checklist for the reviewer
General
Functions constructing generators of maximal subgroups
DefaultFieldOfMatrixGroup
returns the correct field.Functions assembling the list of all maximal subgroups of a certain group
The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.