gap-packages / ClassicalMaximals

Maximal subgroups of classical groups

Other

0 stars 8 forks source link

Checklist for the reviewer

General

[ ] All functions have unit tests

Functions constructing generators of maximal subgroups

[ ] The code which computes and then stores the sizes is correct. To do this one confers to the tables referenced by the code.

[ ] The test suite checks whether all constructed generators are sensible. That is it tests the generators'

[ ] determinants (and if applicable also the spinor norms are correct), and
[ ] compatibility with the correct form,
[ ] DefaultFieldOfMatrixGroup returns the correct field.

Functions assembling the list of all maximal subgroups of a certain group

[ ] The code agrees with the tables in section 8.2 of the book "The Maximal Subgroups of the Low-dimensional Finite Classical Groups".

The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.

Codecov Report

Merging #109 (a67e70a) into main (00b445e) will decrease coverage by 0.91%. The diff coverage is 75.29%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   90.37%   89.46%   -0.92%     
==========================================
  Files          14       14              
  Lines        3939     4194     +255     
==========================================
+ Hits         3560     3752     +192     
- Misses        379      442      +63

Impacted Files	Coverage Δ
gap/Forms.gi	`88.11% <ø> (ø)`
gap/ClassicalMaximals.gi	`67.43% <2.32%> (-3.25%)`	:arrow_down:
gap/SemilinearMatrixGroups.gi	`91.18% <90.09%> (-0.72%)`	:arrow_down: