Orthogonal C5

[TristanPfersdorff]

All the stuff for the C5 subgroups in case O.

Checklist for the reviewer

General

• [ ] All functions have unit tests

Functions constructing generators of maximal subgroups

• [ ] The code which computes and then stores the sizes is correct. To do this one confers to the tables referenced by the code.
• [ ] The test suite checks whether all constructed generators are sensible. That is it tests the generators'
  • [ ] determinants (and if applicable also the spinor norms are correct), and
  • [ ] compatibility with the correct form,
  • [ ] DefaultFieldOfMatrixGroup returns the correct field.

Functions assembling the list of all maximal subgroups of a certain group

• [ ] The code agrees with the tables in section 8.2 of the book "The Maximal Subgroups of the Low-dimensional Finite Classical Groups".

The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.

[codecov[bot]]

Codecov Report

Merging #110 (bffbdd7) into main (9300c14) will decrease coverage by 0.93%. The diff coverage is 64.22%.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   92.79%   91.85%   -0.94%     
==========================================
  Files          14       14              
  Lines        3552     3673     +121     
==========================================
+ Hits         3296     3374      +78     
- Misses        256      299      +43     

Impacted Files	Coverage Δ
gap/ClassicalMaximals.gi	77.87% <2.22%> (-4.51%)	:arrow_down:
gap/SubfieldMatrixGroups.gi	98.46% <100.00%> (+0.64%)	:arrow_up:

[TristanPfersdorff]

Nitpicks are implemented. I also noticed that my tests were apparently so terrible that a large chunk of code was not covered, but that is all fixed now to. This is ready for merging.