search

gap-packages / ClassicalMaximals

Maximal subgroups of classical groups
Other
0 stars 8 forks source link

Orthogonal C4 #113

Closed TristanPfersdorff closed 2 years ago

TristanPfersdorff commented 2 years ago

After some trouble with codecov, this is all done up to some small mathematical gaps. One or two branches in OrthogonalTensorProductStabilizerInOmega are not covered by codecov because I could not find any examples for them and I have good reason to believe that they are impossible, but I have not been able to prove that. The authors of [HR10] hint at having worked through all the cases and calculations according to the Remark after Lemma 7.3, but maybe it's just a Fermat-situation and no one will know for the foreseeable future. The magma-code for this case (epsilon = 1, d1 and d2 even) also suggest that D \in \Omega \iff d \equiv 0 \mod 8, but that's just wrong according to my testing.

codecov[bot] commented 2 years ago

Codecov Report

Merging #113 (9a5850e) into main (a898d1d) will decrease coverage by 0.70%. The diff coverage is 77.25%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   89.46%   88.75%   -0.71%     
==========================================
  Files          14       14              
  Lines        4194     4446     +252     
==========================================
+ Hits         3752     3946     +194     
- Misses        442      500      +58
Impacted Files Coverage Δ
gap/ClassicalMaximals.gi 63.55% <1.75%> (-3.89%) :arrow_down:
gap/TensorProductMatrixGroups.gi 98.73% <98.98%> (+0.39%) :arrow_up:
gap/ReducibleMatrixGroups.gi 98.75% <100.00%> (ø)