search

gap-packages / ClassicalMaximals

Maximal subgroups of classical groups
Other
0 stars 8 forks source link

Main branch fails CI with error "Error, Very bad: image was wrongly recognised and we found out too late" #79

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

I will investigate, and (a) resolve it here and (b) extract a test case for recog

fingolfin commented 2 years ago

Here's a lesson: having tests like

gap> ForAll(testsOrthogonalSubfieldSU, TestOrthogonalSubfieldSU);

makes debugging harder. Rewriting this as

gap> TestOrthogonalSubfieldSU([0, 3, 5]);
gap> TestOrthogonalSubfieldSU([0, 5, 3]);
gap> TestOrthogonalSubfieldSU([-1, 2, 3]);
...

makes it easier to pinpoint the failing case, and also give more accurate progress information for slow tests.

fingolfin commented 2 years ago

First recog bug fix (not the currently failing bug, but another): https://github.com/gap-packages/recog/pull/301

fingolfin commented 2 years ago

Resolved for now