gap-packages / ClassicalMaximals

Maximal subgroups of classical groups
Other
0 stars 8 forks source link

Don't use ForAll to run many tests in a row #81

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

Also add some comments for disabled tests that explain why they are disabled. Ideally all of these would include links to issues reporting the problem. I've only done this in a few cases, the others still need to be analyzed and possible issues be filed.

With this setup, it is much easier to pinpoint which tests precisely is failing; one also gets better (more fine granular) feedback on the progress of the tests.

codecov[bot] commented 2 years ago

Codecov Report

Merging #81 (cfb7052) into main (2b1e0b1) will increase coverage by 1.43%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   90.93%   92.36%   +1.43%     
==========================================
  Files          14       14              
  Lines        2514     2514              
==========================================
+ Hits         2286     2322      +36     
+ Misses        228      192      -36     
Impacted Files Coverage Δ
gap/ExtraspecialNormalizerMatrixGroups.gi 95.33% <0.00%> (+0.58%) :arrow_up:
gap/TensorInducedMatrixGroups.gi 96.29% <0.00%> (+5.55%) :arrow_up:
gap/SubfieldMatrixGroups.gi 93.54% <0.00%> (+15.05%) :arrow_up: