Closed maxhauck closed 2 years ago
Merging #82 (a3da79e) into main (c72b2bd) will decrease coverage by
0.08%
. The diff coverage is70.00%
.
@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 91.01% 90.93% -0.09%
==========================================
Files 14 14
Lines 2504 2514 +10
==========================================
+ Hits 2279 2286 +7
- Misses 225 228 +3
Impacted Files | Coverage Δ | |
---|---|---|
gap/ClassicalMaximals.gi | 84.23% <50.00%> (-0.12%) |
:arrow_down: |
gap/ClassicalNormalizerMatrixGroups.gi | 93.54% <75.00%> (-1.75%) |
:arrow_down: |
Description of your PR
Checklist for the reviewer
General
Functions constructing generators of maximal subgroups
RECOG.TestGroup
from the recog package.DefaultFieldOfMatrixGroup
returns the correct field.Functions assembling the list of all maximal subgroups of a certain group
The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.