gap-packages / ClassicalMaximals

Maximal subgroups of classical groups
Other
0 stars 8 forks source link

Implement Orthogonal C1 symplectic type #85

Closed maxhauck closed 2 years ago

maxhauck commented 2 years ago

Add the following functions:

Modify the following functions:

Tests have now been added as well, lines not covered are almost exclusively error messages.

Checklist for the reviewer

General

Functions constructing generators of maximal subgroups

Functions assembling the list of all maximal subgroups of a certain group

The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.

maxhauck commented 2 years ago

@fingolfin Two things:

  1. After being a bit puzzled for a while, we discovered that GAP uses different standard orthogonal forms for SO(epsilon, d, q) and Omega(epsilon, d, q) ... - we therefore decided to conjugate the constructed subgroup so that it is inside Omega(epsilon, d, q) and consequently not inside SO(epsilon, d, q), which should be what we want, right?

  2. We added "Constructing maximal subgroups of orthogonal subgroups" to the bibliography by mimicking what you did as best as we could, but we could not for the life of us figure out what to put as MRNUMBER and MRREVIEWER in ClassicalMaximals.bib ... - so what to put there?

codecov[bot] commented 2 years ago

Codecov Report

Merging #85 (087e5ad) into main (927d284) will decrease coverage by 0.46%. The diff coverage is 90.10%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   93.56%   93.09%   -0.47%     
==========================================
  Files          14       14              
  Lines        2485     2665     +180     
==========================================
+ Hits         2325     2481     +156     
- Misses        160      184      +24     
Impacted Files Coverage Δ
gap/Forms.gi 89.67% <88.37%> (+0.54%) :arrow_up:
gap/Utils.gi 92.93% <89.55%> (-1.10%) :arrow_down:
gap/ReducibleMatrixGroups.gi 98.01% <91.42%> (-1.39%) :arrow_down:
gap/Forms.gd 100.00% <100.00%> (ø)
gap/SubfieldMatrixGroups.gi 97.79% <100.00%> (ø)
gap/ClassicalMaximals.gi 83.27% <0.00%> (-1.40%) :arrow_down:
gap/TensorInducedMatrixGroups.gi 98.38% <0.00%> (+0.27%) :arrow_up:
fingolfin commented 2 years ago

Regarding Omega: this is known, see https://github.com/gap-system/gap/issues/500. Since it's been like this "forever", we can't simply change it without risking to break existing code out there. The solution we came up with is that in GAP 4.12, various constructors will allow the user to optionally specify a form.