gap-packages / ClassicalMaximals

Maximal subgroups of classical groups
Other
0 stars 8 forks source link

Implement QuadraticForm #87

Closed maxhauck closed 2 years ago

maxhauck commented 2 years ago

Fully implement QuadraticForm. Now with tests!

Checklist for the reviewer

General

Functions constructing generators of maximal subgroups

Functions assembling the list of all maximal subgroups of a certain group

The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.

codecov[bot] commented 2 years ago

Codecov Report

Merging #87 (7736b24) into main (8e6efe7) will increase coverage by 0.01%. The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   93.09%   93.11%   +0.01%     
==========================================
  Files          14       14              
  Lines        2665     2686      +21     
==========================================
+ Hits         2481     2501      +20     
- Misses        184      185       +1     
Impacted Files Coverage Δ
gap/Forms.gi 90.17% <91.30%> (+0.49%) :arrow_up: