gap-packages / ClassicalMaximals

Maximal subgroups of classical groups
Other
0 stars 8 forks source link

Replace RECOG.TestGroup by new CheckSize helper #98

Closed fingolfin closed 2 years ago

fingolfin commented 2 years ago

It is not the job of this package to test recog, but the function RECOG.TestGroup is written for that task, and e.g. performs group recognition multiple times. But we really only want to use recog to compute a group size in order to test our code. So let's do just that, and nothing more.

Description of your PR

Checklist for the reviewer

General

Functions constructing generators of maximal subgroups

Functions assembling the list of all maximal subgroups of a certain group

The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.

codecov[bot] commented 2 years ago

Codecov Report

Merging #98 (4f17f6b) into main (b1944c3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          14       14           
  Lines        2860     2860           
=======================================
  Hits         2736     2736           
  Misses        124      124