gap-packages / ClassicalMaximals

Maximal subgroups of classical groups

Other

0 stars 8 forks source link

Checklist for the reviewer

General

[ ] All functions have unit tests

Functions constructing generators of maximal subgroups

[ ] The code which computes and then stores the sizes is correct. To do this one confers to the tables referenced by the code. Tests for the group size should use RECOG.TestGroup from the recog package.

[ ] The test suite checks whether all constructed generators are sensible. That is it tests the generators'

[ ] determinants (and if applicable also the spinor norms are correct), and
[ ] compatibility with the correct form,
[ ] DefaultFieldOfMatrixGroup returns the correct field.

Functions assembling the list of all maximal subgroups of a certain group

[ ] The code agrees with the tables in section 8.2 of the book "The Maximal Subgroups of the Low-dimensional Finite Classical Groups".

The reviewer doesn't need to compare our results to magma's results. That's the job of the person implementing the code.

Codecov Report

Merging #99 (7676830) into main (b1944c3) will decrease coverage by 0.41%. The diff coverage is 96.07%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   95.66%   95.24%   -0.42%     
==========================================
  Files          14       14              
  Lines        2860     3072     +212     
==========================================
+ Hits         2736     2926     +190     
- Misses        124      146      +22

Impacted Files	Coverage Δ
gap/ClassicalMaximals.gi	`96.78% <ø> (-0.04%)`	:arrow_down:
gap/Utils.gi	`93.20% <94.66%> (+0.37%)`	:arrow_up:
gap/Forms.gd	`100.00% <100.00%> (ø)`
gap/Forms.gi	`86.50% <100.00%> (+0.57%)`	:arrow_up:
gap/ReducibleMatrixGroups.gi	`98.03% <100.00%> (-0.04%)`	:arrow_down:
gap/SemilinearMatrixGroups.gi	`91.90% <0.00%> (-3.05%)`	:arrow_down: