Closed CMurtagh-LGTM closed 1 year ago
Merging #128 (fa7846e) into master (518a8a6) will increase coverage by
17.52%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #128 +/- ##
===========================================
+ Coverage 8.95% 26.47% +17.52%
===========================================
Files 8 14 +6
Lines 715 865 +150
===========================================
+ Hits 64 229 +165
+ Misses 651 636 -15
Impacted Files | Coverage Δ | |
---|---|---|
gap/JupyterUtil.gd | 100.00% <0.00%> (ø) |
|
gap/JupyterStream.gd | 100.00% <0.00%> (ø) |
|
gap/JupyterHelp.gd | 100.00% <0.00%> (ø) |
|
gap/JupyterRenderable.gd | 100.00% <0.00%> (ø) |
|
gap/JupyterKernel.gd | 100.00% <0.00%> (ø) |
|
gap/JupyterMsg.gd | 100.00% <0.00%> (ø) |
|
gap/JupyterCompletion.gi | 90.00% <0.00%> (+0.52%) |
:arrow_up: |
gap/JupyterInspection.gi | 71.83% <0.00%> (+2.71%) |
:arrow_up: |
gap/JupyterKernel.gi | 8.61% <0.00%> (+8.61%) |
:arrow_up: |
gap/JupyterHelp.gi | 8.64% <0.00%> (+8.64%) |
:arrow_up: |
... and 4 more |
Thanks @CMurtagh-LGTM! @ZachNewbery does this look good to you?
Yup, all looks good to me!
On Tue, 13 Dec 2022, 08:58 Olexandr Konovalov, @.***> wrote:
Thanks @CMurtagh-LGTM https://github.com/CMurtagh-LGTM! @ZachNewbery https://github.com/ZachNewbery does this look good to you?
— Reply to this email directly, view it on GitHub https://github.com/gap-packages/JupyterKernel/pull/128#issuecomment-1347958135, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJBAXSHOJJFHJXLALIWP3TWNA3DBANCNFSM6AAAAAASGIMDIE . You are receiving this because you were mentioned.Message ID: @.***>
CI failure about io not being available - I don't think that's caused by these changes
CI passes in the main branch - not testing under GAP 4.9 anymore. Thanks both.
Installing the python package via
pip install .
was giving me the errorMultiple top-level packages discovered in a flat-layout: ['tst', 'etc', 'gap', 'demos'].
.Here are the versions my things