gap-packages / JupyterKernel

Native Jupyter kernel for GAP
https://gap-packages.github.io/JupyterKernel/
BSD 3-Clause "New" or "Revised" License
19 stars 12 forks source link

Fix Multiple top-level packages error #128

Closed CMurtagh-LGTM closed 1 year ago

CMurtagh-LGTM commented 1 year ago

Installing the python package via pip install . was giving me the error Multiple top-level packages discovered in a flat-layout: ['tst', 'etc', 'gap', 'demos']..

Here are the versions my things

❯ python --version
Python 3.10.8
❯ pip --version
pip 22.3.1 from /usr/lib/python3.10/site-packages/pip (python 3.10)
❯ pip show setuptools
Name: setuptools
Version: 65.2.0
Summary: Easily download, build, install, upgrade, and uninstall Python packages
Home-page: https://github.com/pypa/setuptools
Author: Python Packaging Authority
Author-email: distutils-sig@python.org
License:
Location: /usr/lib/python3.10/site-packages
Requires: appdirs, jaraco.text, more-itertools, ordered-set, packaging, pyparsing, tomli, validate-pyproject
Required-by: jupyter_packaging
codecov[bot] commented 1 year ago

Codecov Report

Merging #128 (fa7846e) into master (518a8a6) will increase coverage by 17.52%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #128       +/-   ##
===========================================
+ Coverage    8.95%   26.47%   +17.52%     
===========================================
  Files           8       14        +6     
  Lines         715      865      +150     
===========================================
+ Hits           64      229      +165     
+ Misses        651      636       -15     
Impacted Files Coverage Δ
gap/JupyterUtil.gd 100.00% <0.00%> (ø)
gap/JupyterStream.gd 100.00% <0.00%> (ø)
gap/JupyterHelp.gd 100.00% <0.00%> (ø)
gap/JupyterRenderable.gd 100.00% <0.00%> (ø)
gap/JupyterKernel.gd 100.00% <0.00%> (ø)
gap/JupyterMsg.gd 100.00% <0.00%> (ø)
gap/JupyterCompletion.gi 90.00% <0.00%> (+0.52%) :arrow_up:
gap/JupyterInspection.gi 71.83% <0.00%> (+2.71%) :arrow_up:
gap/JupyterKernel.gi 8.61% <0.00%> (+8.61%) :arrow_up:
gap/JupyterHelp.gi 8.64% <0.00%> (+8.64%) :arrow_up:
... and 4 more
olexandr-konovalov commented 1 year ago

Thanks @CMurtagh-LGTM! @ZachNewbery does this look good to you?

ZachNewbery commented 1 year ago

Yup, all looks good to me!

On Tue, 13 Dec 2022, 08:58 Olexandr Konovalov, @.***> wrote:

Thanks @CMurtagh-LGTM https://github.com/CMurtagh-LGTM! @ZachNewbery https://github.com/ZachNewbery does this look good to you?

— Reply to this email directly, view it on GitHub https://github.com/gap-packages/JupyterKernel/pull/128#issuecomment-1347958135, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALJBAXSHOJJFHJXLALIWP3TWNA3DBANCNFSM6AAAAAASGIMDIE . You are receiving this because you were mentioned.Message ID: @.***>

ZachNewbery commented 1 year ago

CI failure about io not being available - I don't think that's caused by these changes

olexandr-konovalov commented 1 year ago

CI passes in the main branch - not testing under GAP 4.9 anymore. Thanks both.